Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variation title generate event #707

Open
wants to merge 5 commits into
base: 8.x-2.x
Choose a base branch
from
Open

Variation title generate event #707

wants to merge 5 commits into from

Conversation

bmcclure
Copy link
Contributor

@bmcclure bmcclure commented Apr 4, 2017

Sorry for the stray merge commits, there are no changes from those merges represented here.

This is an attempt to resolve https://www.drupal.org/node/2846895 by adding a new event that's dispatched after generating the variation title, before saving it to the variation.

mglaman
mglaman requested changes Apr 4, 2017
View reviewed changes
Copy link
Contributor

@mglaman mglaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test module, like commerce_product_test even, which subscribes to this event. If the product's SKU is GENERATE_TEST (or something) it'll react and change the title. So we can prove it works and document the feature via tests.

@bojanz bojanz force-pushed the 8.x-2.x branch 7 times, most recently from 6be1d5c to b8a7444 Compare April 27, 2017 20:46
@bmcclure
Copy link
Contributor Author

bmcclure commented May 4, 2017

I'll work on these tests ASAP btw, sorry for leaving this out there for so long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mglaman mglaman mglaman requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmcclure @mglaman